Menu

#188 TIP#242: add -initialtype option

TIP Implementation
closed-fixed
9
2007-10-25
2005-03-04
No

Here's the *nix and Win implementation for the
-initialtype tip. I'm assuming the macosx impl. will be
just as trivial.

-Brian

Discussion

  • Brian Griffin

    Brian Griffin - 2005-03-04

    Patches to implement -initialtype

     
  • Donal K. Fellows

    • summary: Tip to add -initialtype --> TIP#242: add -initialtype option
     
  • Brian Griffin

    Brian Griffin - 2005-06-01

    Unix final implementation

     
  • Brian Griffin

    Brian Griffin - 2005-06-01

    Logged In: YES
    user_id=22949

    Here's the modified tkfbox.tcl for Unix as per the approved TIP. I'm still
    working on Windows and Mac OS X, and the documentation.

     
  • Brian Griffin

    Brian Griffin - 2005-06-01

    Windows final implementation

     
  • Brian Griffin

    Brian Griffin - 2005-06-01

    Logged In: YES
    user_id=22949

    Here's the Windows implementation.

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2005-06-01

    Logged In: YES
    user_id=72656

    Is OS X far behind? I'd like to not add them to 8.5a3
    unless there are symmetric implementations

     
  • Brian Griffin

    Brian Griffin - 2005-06-01

    Man page with new switch added.

     
  • Brian Griffin

    Brian Griffin - 2005-06-01

    Logged In: YES
    user_id=22949

    Here's the man page.

    The Mac changes are in progress. I should have those
    tonight, hopefully. Question: currently tk_getSaveFile
    ignores the filtertypes on Mac, but this enhancement makes
    filtertypes useful on a Mac. Should I try and get this in also?

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2005-06-01

    Logged In: YES
    user_id=72656

    I think that would be useful, but not a requirement to finish.

     
  • Brian Griffin

    Brian Griffin - 2005-06-04

    Logged In: YES
    user_id=22949

    Here's the macosx flavor. Later I'll try to add filetypes filtering to
    tk_getSaveFile (currently disabled). It now makes sense now since users
    can read the selected format.

     
  • Brian Griffin

    Brian Griffin - 2005-06-05

    Logged In: YES
    user_id=22949

    Here's the Strict Motif version for this TIP.

     
  • Brian Griffin

    Brian Griffin - 2005-06-05

    Strict Motif version

     
  • Brian Griffin

    Brian Griffin - 2005-06-05

    Logged In: YES
    user_id=22949

    I fixed a coding problem pointed out by Jim Ingham. I also cleaned up
    warnings and two spots, lines 1013, 1037 where the warnings look like
    coding errors. Someone should look at these and verify.

     
  • Brian Griffin

    Brian Griffin - 2005-06-05

    MacOSX impl. + bug fixes

     
  • Brian Griffin

    Brian Griffin - 2005-06-05

    Logged In: YES
    user_id=22949

    Removing previous mac implementation.

     
  • Brian Griffin

    Brian Griffin - 2005-06-06

    Test updated to cover -typevariable

     
  • Brian Griffin

    Brian Griffin - 2005-06-06

    Logged In: YES
    user_id=22949

    Updated filebox.test to reflect changes and add test for new option.

    The new test uncovered a quirk (bug?) in the tkfbox that I've also fixed
    (new tkfbox.tcl to follow).

    quirk: call tk_getOpenFile with a filetypes list. On the next call, use an
    empty filetypes list. The filter menu is disabled, but the grayed text still
    displays the last filter setting, even though this call contains no filters.

     
  • Brian Griffin

    Brian Griffin - 2005-06-06

    Unix implementation + bug fix.

     
  • Brian Griffin

    Brian Griffin - 2005-06-06

    Logged In: YES
    user_id=22949

    Updated tkfbox.tcl to clear filter menubutton when filetypes is empty.

     
  • Donal K. Fellows

    • priority: 5 --> 9
     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2007-10-15

    Logged In: YES
    user_id=72656
    Originator: NO

    I was trying to implement this, but it turns out that changes in tkfbox.tcl since the patch have affected it's applicability. Please review - if we can get it done in the next week, it can go in. If you diff against 8.5a3 you get the relevant actual changes. That works for xmfbox.tcl, but not tkfbox.tcl (didn't check the .c as I was stymied by tkfbox.tcl).

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2007-10-25

    integrated patch for 8.5b2

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2007-10-25
    • status: open --> closed-fixed
     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2007-10-25

    Logged In: YES
    user_id=72656
    Originator: NO

    Attached is 8.5 patch contributed by Brian, massaged by me and integrated into head for 8.5b2.
    File Added: tip242.diff