The bug is triggered when using the !addplugindir with a relative path and then changing the working directory with !cd before the plugin is used. When the plugin is supposed to be added makensis uses the relative path from !addplugindir to the current directory. If the current directory has been changed since declaration, the custom plugin directory cannot be found and makensis simply skips copying the plugin to the $PLUGINSDIR. This behavior can be seen with a "Procmon"-trace for instance.
Priority should probably be quite high since this can lead to a broken installer, with no clues or error messages during compile.
@Anders can we resolve the silent failure part too?
TOK__PLUGINCOMMAND
is not checkingfiles_added == 1
afterdo_add_file()
call.https://github.com/kichik/nsis/blob/c81d5340487ff451ce6776be4fb7fade798797c5/Source/script.cpp#L5139