Menu

#1264 !addplugindir can silently fail to include required plugins in installer

3.0 Series
closed
nobody
None
5
2021-05-05
2021-04-29
No
  1. NSIS 3.06.1
  2. No error message during compile. At run time, the installer fails to find the plugins and this leads to unexpected results.
  3. See attached zip-file.

The bug is triggered when using the !addplugindir with a relative path and then changing the working directory with !cd before the plugin is used. When the plugin is supposed to be added makensis uses the relative path from !addplugindir to the current directory. If the current directory has been changed since declaration, the custom plugin directory cannot be found and makensis simply skips copying the plugin to the $PLUGINSDIR. This behavior can be seen with a "Procmon"-trace for instance.

Priority should probably be quite high since this can lead to a broken installer, with no clues or error messages during compile.

1 Attachments

Discussion

  • Anders

    Anders - 2021-05-02
    • status: open --> closed
     

Log in to post a comment.