Ever since "2010-11-11 ntlm: use is_empty() to check credential parameters" I cannot authenticate. I've attached the pidgin debug log. Please let me know what further information you require.
You removed any interesting information that might have been in the log,
I'm assuming that either your domain, user name or password is an empty string? That would be the only thing where that change would have any affect. As far as I have understood NTLM authentication, none of these values may be an empty string.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Sorry for my over paranoia. I realize it was silly; however there were no blank fields in the log. I did just get it to work though. I had been using user@domain for what seems like forever. In this case I switched it to domain\user. I don't know why one way works and one doesn't but that seems relevant. Please let me know if you have questions or need more information. I'll leave all the relevant information in next time. I promise. :)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Then commit 68e7269 can't be the root cause of your problem.
Please run a git bisect:
- go back to 1.11.2:
$ git reset --hard 1.11.2
HEAD is now at f87e2b6 Updated to release 1.11.2 (Another Bugfixes release only)
compile & make sure that it WORKS
- go to latest code:
$ git pull
Updating f87e2b6..891191f
Fast-forward
...
$ git status
# On branch mob
nothing to commit (working directory clean)
compile & make sure that it FAILS
- start bisecting:
$ git bisect start HEAD 1.11.2
Bisecting: 97 revisions left to test after this (roughly 7 steps)
[2fb8b56f2f1c46d3edc273d995a0ac9b7cf9d169] chat: make Invite... menu work again
compile & make sure that it WORKS (-> git bisect good) or FAILS (-> git bisect bad) until git tells you the failing commit.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
My mistake... somehow I didn't compile the right code. I cleaned everything up and then verified by looking this time at sip-sec-ntlm.c. The latest commit does work with user@domain. I still don't understand the behavior. Why does an is_empty break it? I would expect either nothing works or everything works.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Pidgin Debug window log
You removed any interesting information that might have been in the log,
I'm assuming that either your domain, user name or password is an empty string? That would be the only thing where that change would have any affect. As far as I have understood NTLM authentication, none of these values may be an empty string.
Sorry for my over paranoia. I realize it was silly; however there were no blank fields in the log. I did just get it to work though. I had been using user@domain for what seems like forever. In this case I switched it to domain\user. I don't know why one way works and one doesn't but that seems relevant. Please let me know if you have questions or need more information. I'll leave all the relevant information in next time. I promise. :)
I reverted the domain part of commit 68e7269.
git commit 891191f.
This still only works with domain\user and not user@domain.
Then commit 68e7269 can't be the root cause of your problem.
Please run a git bisect:
- go back to 1.11.2:
$ git reset --hard 1.11.2
HEAD is now at f87e2b6 Updated to release 1.11.2 (Another Bugfixes release only)
compile & make sure that it WORKS
- go to latest code:
$ git pull
Updating f87e2b6..891191f
Fast-forward
...
$ git status
# On branch mob
nothing to commit (working directory clean)
compile & make sure that it FAILS
- start bisecting:
$ git bisect start HEAD 1.11.2
Bisecting: 97 revisions left to test after this (roughly 7 steps)
[2fb8b56f2f1c46d3edc273d995a0ac9b7cf9d169] chat: make Invite... menu work again
compile & make sure that it WORKS (-> git bisect good) or FAILS (-> git bisect bad) until git tells you the failing commit.
My mistake... somehow I didn't compile the right code. I cleaned everything up and then verified by looking this time at sip-sec-ntlm.c. The latest commit does work with user@domain. I still don't understand the behavior. Why does an is_empty break it? I would expect either nothing works or everything works.
is_empty() returns true for NULL, "" (empty string) and a string only containing white space.
The error was that an empty domain (i.e. "") is actually allowed and changing the check from !domain to is_empty(domain) broke that.
Closing bug for good. Thanks for checking again.