Menu

#254 ExDLL still built with SKIPPLUGINS=all

Unstable
closed-accepted
None
5
2014-10-05
2014-07-04
No

Up until [r5826], setting SKIPMISC=all would prevent ExDLL from being built. ExDLL is now built along with the "plugins" group and tested against the SKIPPLUGINS list - but it can't be added to the list, ie by specifying SKIPPLUGINS=all. I'm attaching a patch that skips building ExDLL for SKIPPLUGINS=all. A possible downside of this patch is that if you build with SKIPPLUGINS=ExDLL then other plugins will fail to build since they apparently depend on ExDLL.

Index: SConstruct
===================================================================
--- SConstruct  (revision 6510)
+++ SConstruct  (working copy)
@@ -160,7 +160,7 @@
 # installation
 opts.Add(('PREFIX', 'Installation prefix', dirs['prefix']))
 opts.Add(ListVariable('SKIPSTUBS', 'A list of stubs that will not be built', 'none', stubs))
-opts.Add(ListVariable('SKIPPLUGINS', 'A list of plug-ins that will not be built', 'none', plugins))
+opts.Add(ListVariable('SKIPPLUGINS', 'A list of plug-ins that will not be built', 'none', plugin_libs + plugins))
 opts.Add(ListVariable('SKIPUTILS', 'A list of utilities that will not be built', 'none', utils))
 opts.Add(ListVariable('SKIPMISC', 'A list of plug-ins that will not be built', 'none', misc))
 opts.Add(ListVariable('SKIPDOC', 'A list of doc files that will not be built/installed', 'none', doc))
1 Attachments

Related

Commit: [r5826]

Discussion

  • Amir Szekely

    Amir Szekely - 2014-10-05
    • status: open --> closed-accepted
    • assigned_to: Amir Szekely
     
  • Amir Szekely

    Amir Szekely - 2014-10-05

    Thanks. Patch applied in [r6544].

     

    Related

    Commit: [r6544]


Log in to post a comment.