NSIS: Nullsoft Scriptable Install System / Bugs / #1171 the '/OEM" switch is broken for nsExec::ExecToLog

Windows installer development tool

#1171 the '/OEM" switch is broken for nsExec::ExecToLog

Milestone: 3.0 Series

Status: closed-fixed

Owner: nobody

Labels: None

Priority: 5

Updated: 2017-01-15

Created: 2017-01-08

Creator: Ilia Chipitsine

Private: No

I want to use "Unicode true" mode and also I run "sc.exe" during install, on russian windows it outputs in cp866, so I used to use /OEM to make output look shine, here's sample nsis script

!include "MUI.nsh"

Name "example"
OutFile "example.exe"
;Unicode true

!insertmacro MUI_LANGUAGE "Russian"

Section
  nsExec::ExecToLog /OEM '"$SYSDIR\sc.exe" query'
SectionEnd

I attached couple of screenshots (nsis-2.50 and nsis-3.01)

2 Attachments

nsis2.png

nsis3.png

Discussion

Ilia Chipitsine - 2017-01-08

nsis3 screenshot is produced with "Unicode true" uncommented

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anders - 2017-01-10

It looks like the Unicode version does not check the OEM flag when doing a conversion, this should be easy to fix...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anders - 2017-01-15

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ilia Chipitsine - 2017-01-15

thank you for the fix.
when it is going to be released?

also, I did not find any CI, I should build snapshot by myself?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

the '/OEM" switch is broken for nsExec::ExecToLog

Windows installer development tool

Group

Searches

Help

#1171 the '/OEM" switch is broken for nsExec::ExecToLog

Discussion